From 5ec07d448084fd213c700fa46e17eed78b89a547 Mon Sep 17 00:00:00 2001
From: paritosh18 <paritosh898384.com>
Date: Mon, 23 Feb 2026 18:56:08 +0530
Subject: [PATCH] Refactor user ID validation and optimize city search results.
 Updated user ID check to use Number.isNaN for better clarity. Added a comment
 indicating that city results are capped at 50 in the database query to reduce
 latency.

---
 src/modules/user/handlers/connections/searchCities.ts | 4 ++--
 src/modules/user/services/user.service.ts             | 6 ++++--
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/src/modules/user/handlers/connections/searchCities.ts b/src/modules/user/handlers/connections/searchCities.ts
index 1b1ba7d..f25acb7 100644
--- a/src/modules/user/handlers/connections/searchCities.ts
+++ b/src/modules/user/handlers/connections/searchCities.ts
@@ -30,7 +30,7 @@ export const handler = safeHandler(
     const userInfo = await verifyUserToken(token);
     const userId = Number(userInfo.id);
 
-    if (!userId || isNaN(userId)) {
+    if (!userId || Number.isNaN(userId)) {
       throw new ApiError(400, 'Invalid user ID');
     }
 
@@ -78,7 +78,7 @@ export const handler = safeHandler(
       body: JSON.stringify({
         success: true,
         message: 'Cities found successfully',
-        data: results,
+        data: results, // already capped at 50 in DB query
         count: results.length,
       }),
     };
diff --git a/src/modules/user/services/user.service.ts b/src/modules/user/services/user.service.ts
index 1273ed6..4d3aae6 100644
--- a/src/modules/user/services/user.service.ts
+++ b/src/modules/user/services/user.service.ts
@@ -1932,9 +1932,11 @@ export class UserService {
         id: true,
         cityName: true,
         stateXid: true,
-        isActive: true,
-        createdAt: true,
       },
+      orderBy: {
+        cityName: 'asc',
+      },
+      take: 50, // reduce latency by limiting results at DB level
     });
 
     return results;