From 7b9763c6684bb826440a3d81c4a41a4b5811562d Mon Sep 17 00:00:00 2001 From: Mayank Mishra Date: Fri, 5 Dec 2025 18:51:50 +0530 Subject: [PATCH 1/2] Enhance getAllHostActivityForMinglar method to exclude activities with DRAFT_PQ status --- src/modules/minglaradmin/services/minglar.service.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/modules/minglaradmin/services/minglar.service.ts b/src/modules/minglaradmin/services/minglar.service.ts index 32080ec..a5192c3 100644 --- a/src/modules/minglaradmin/services/minglar.service.ts +++ b/src/modules/minglaradmin/services/minglar.service.ts @@ -260,6 +260,7 @@ export class MinglarService { async getAllHostActivityForMinglar(search?: string, hostXid?: number, paginationOptions?: { page: number; limit: number; skip: number }) { const whereClause: any = { isActive: true, + activityInternalStatus: { notIn: [ACTIVITY_INTERNAL_STATUS.DRAFT_PQ] }, ...(hostXid ? { hostXid } : {}), }; From 06010ef6e8f4ffe98d2809b761de27631cdf92ac Mon Sep 17 00:00:00 2001 From: Mayank Mishra Date: Fri, 5 Dec 2025 19:21:19 +0530 Subject: [PATCH 2/2] Refactor API paths for acceptPQByAM and rejectPQQByAM to remove activityId from URL and update request body parsing for activityId --- serverless/functions/minglaradmin.yml | 4 ++-- .../handlers/hosthub/hosts/acceptPQByAM.ts | 15 ++++++++++++++- .../handlers/hosthub/hosts/rejectPQQbyAM.ts | 15 ++++++++++++++- 3 files changed, 30 insertions(+), 4 deletions(-) diff --git a/serverless/functions/minglaradmin.yml b/serverless/functions/minglaradmin.yml index d0e5630..3a0e234 100644 --- a/serverless/functions/minglaradmin.yml +++ b/serverless/functions/minglaradmin.yml @@ -340,7 +340,7 @@ RejectPQQByAM: - ${file(./serverless/patterns/base.yml):pattern4} events: - httpApi: - path: /minglaradmin/hosthub/hosts/reject-pq-by-am/{activityId} + path: /minglaradmin/hosthub/hosts/reject-pq-by-am method: patch acceptPQByAM: @@ -356,7 +356,7 @@ acceptPQByAM: - ${file(./serverless/patterns/base.yml):pattern4} events: - httpApi: - path: /minglaradmin/hosthub/hosts/accept-pq-by-am/{activityId} + path: /minglaradmin/hosthub/hosts/accept-pq-by-am method: patch rejectHostApplication: diff --git a/src/modules/minglaradmin/handlers/hosthub/hosts/acceptPQByAM.ts b/src/modules/minglaradmin/handlers/hosthub/hosts/acceptPQByAM.ts index a8af733..13b207c 100644 --- a/src/modules/minglaradmin/handlers/hosthub/hosts/acceptPQByAM.ts +++ b/src/modules/minglaradmin/handlers/hosthub/hosts/acceptPQByAM.ts @@ -8,6 +8,10 @@ import ApiError from '../../../../../common/utils/helper/ApiError'; const prismaService = new PrismaService(); const minglarService = new MinglarService(prismaService); +interface Body { + activityId: number; +} + export const handler = safeHandler(async ( event: APIGatewayProxyEvent, context?: Context @@ -17,7 +21,16 @@ export const handler = safeHandler(async ( const userInfo = await verifyMinglarAdminToken(token); - const activityId = event.pathParameters?.activityId; + // Parse request body + let body: Body; + + try { + body = event.body ? JSON.parse(event.body) : {}; + } catch (error) { + throw new ApiError(400, 'Invalid JSON in request body'); + } + + const { activityId } = body; if (!activityId) { throw new ApiError(400, 'activityId is required'); diff --git a/src/modules/minglaradmin/handlers/hosthub/hosts/rejectPQQbyAM.ts b/src/modules/minglaradmin/handlers/hosthub/hosts/rejectPQQbyAM.ts index acb60af..fec946a 100644 --- a/src/modules/minglaradmin/handlers/hosthub/hosts/rejectPQQbyAM.ts +++ b/src/modules/minglaradmin/handlers/hosthub/hosts/rejectPQQbyAM.ts @@ -8,6 +8,10 @@ import { MinglarService } from '../../../services/minglar.service'; const prismaService = new PrismaService(); const minglarService = new MinglarService(prismaService); +interface Body { + activityId: number; +} + export const handler = safeHandler(async ( event: APIGatewayProxyEvent, context?: Context @@ -17,7 +21,16 @@ export const handler = safeHandler(async ( const userInfo = await verifyMinglarAdminToken(token); - const activityId = event.pathParameters?.activityId; + // Parse request body + let body: Body; + + try { + body = event.body ? JSON.parse(event.body) : {}; + } catch (error) { + throw new ApiError(400, 'Invalid JSON in request body'); + } + + const { activityId } = body; if (!activityId) { throw new ApiError(400, 'activityId is required');