From 5742a18d09a692f8358b1e4df8b456e403c06796 Mon Sep 17 00:00:00 2001 From: Bilal Date: Tue, 22 Oct 2024 08:47:54 +0530 Subject: [PATCH] fixes --- .../Authentication/Controller/AppUpdateVC.swift | 6 ++++-- WOKA/Helpers/DropDown/src/DropDown.swift | 3 ++- WOKA/Karaoke/ViewModel/JWKaraokePlayerVM.swift | 3 ++- WOKA/Theme/Controller/PlayerVC.swift | 3 ++- WOKA/Theme/ViewModel/PlayerVM.swift | 3 ++- WOKA/Theme/ViewModel/ThemeOneVM.swift | 17 +++++++---------- WOKA/WebSeries/Controller/WebSeriesVC.swift | 3 ++- 7 files changed, 21 insertions(+), 17 deletions(-) diff --git a/WOKA/Authentication/Controller/AppUpdateVC.swift b/WOKA/Authentication/Controller/AppUpdateVC.swift index d0c385b..aafc996 100644 --- a/WOKA/Authentication/Controller/AppUpdateVC.swift +++ b/WOKA/Authentication/Controller/AppUpdateVC.swift @@ -27,14 +27,16 @@ class AppUpdateVC: UIViewController { if isForceUpdate{ skipBtn.isHidden = true - DispatchQueue.main.async { [self] in + DispatchQueue.main.async { [weak self] in + guard let self else{return} updateBtn.applyGradient(colors: [color1, color2], startPoint: CGPoint(x: 0, y: 0), endPoint: CGPoint(x: 0.8, y: 0)) updateBtn.roundCorner() } }else{ skipBtn.isHidden = false - DispatchQueue.main.async { [self] in + DispatchQueue.main.async { [weak self] in + guard let self else{return} updateBtn.applyGradient(colors: [color1, color2], startPoint: CGPoint(x: 0, y: 0), endPoint: CGPoint(x: 0.8, y: 0)) updateBtn.roundCorner() skipBtn.applyGradient(colors: [color1, color2], startPoint: CGPoint(x: 0, y: 0), endPoint: CGPoint(x: 0.8, y: 0)) diff --git a/WOKA/Helpers/DropDown/src/DropDown.swift b/WOKA/Helpers/DropDown/src/DropDown.swift index 9139e63..9e28bc8 100644 --- a/WOKA/Helpers/DropDown/src/DropDown.swift +++ b/WOKA/Helpers/DropDown/src/DropDown.swift @@ -517,7 +517,8 @@ private extension DropDown { func setup() { tableView.register(cellNib, forCellReuseIdentifier: DPDConstant.ReusableIdentifier.DropDownCell) - DispatchQueue.main.async { + DispatchQueue.main.async { [weak self] in + guard let self else{return} //HACK: If not done in dispatch_async on main queue `setupUI` will have no effect self.updateConstraintsIfNeeded() self.setupUI() diff --git a/WOKA/Karaoke/ViewModel/JWKaraokePlayerVM.swift b/WOKA/Karaoke/ViewModel/JWKaraokePlayerVM.swift index 90338c6..3a9aea3 100644 --- a/WOKA/Karaoke/ViewModel/JWKaraokePlayerVM.swift +++ b/WOKA/Karaoke/ViewModel/JWKaraokePlayerVM.swift @@ -52,7 +52,8 @@ class JWKaraokePlayerVM{ func saveToFilesApp() { guard let mixedAudioURL = mixedAudioURL else { return } - DispatchQueue.main.async { + DispatchQueue.main.async { [weak self] in + guard let self else{return} let documentPicker = UIDocumentPickerViewController(url: mixedAudioURL, in: .exportToService) documentPicker.delegate = self.vc self.vc.present(documentPicker, animated: true, completion: nil) diff --git a/WOKA/Theme/Controller/PlayerVC.swift b/WOKA/Theme/Controller/PlayerVC.swift index 69d6dc0..bd2f146 100644 --- a/WOKA/Theme/Controller/PlayerVC.swift +++ b/WOKA/Theme/Controller/PlayerVC.swift @@ -457,7 +457,8 @@ extension PlayerVC { } } else { // Fallback code for earlier iOS versions - DispatchQueue.main.async { + DispatchQueue.main.async { [weak self] in + guard let self else{return} self.dismiss(animated: true) } } diff --git a/WOKA/Theme/ViewModel/PlayerVM.swift b/WOKA/Theme/ViewModel/PlayerVM.swift index e4d03a1..aff8882 100644 --- a/WOKA/Theme/ViewModel/PlayerVM.swift +++ b/WOKA/Theme/ViewModel/PlayerVM.swift @@ -119,7 +119,8 @@ class PlayerVM{ } updateClicks() - DispatchQueue.main.async { + DispatchQueue.main.async { [weak self] in + guard let self else{return} if #available(iOS 16.0, *) { // Code for iOS 15.0 and above appDelegate.deviceOrientation = .portrait diff --git a/WOKA/Theme/ViewModel/ThemeOneVM.swift b/WOKA/Theme/ViewModel/ThemeOneVM.swift index c8129c5..8f56ee0 100644 --- a/WOKA/Theme/ViewModel/ThemeOneVM.swift +++ b/WOKA/Theme/ViewModel/ThemeOneVM.swift @@ -660,8 +660,6 @@ class ThemeOneVM{ let details = period.details // Update view's background color with a gradient or single color -// DispatchQueue.main.async { [weak self] in -// guard let self else{return} if period.details.dayCycle == .night{ startStarGlowAnimation() }else{ @@ -671,15 +669,14 @@ class ThemeOneVM{ !image.isHidden ? image.isHidden = true : nil } } - DispatchQueue.main.async { - self.vc.gradientView.applyGradient(colors: [details.color1, details.color2], startPoint: CGPoint(x: 0, y: 0), endPoint: CGPoint(x: 0, y: 0.8)) - self.vc.nameLabel.textColor = details.textColor - self.vc.HelloLabel.textColor = details.textColor - self.vc.welcomeLabel.textColor = details.textColor - self.vc.homeGrass.image = UIImage(named: details.grass) + DispatchQueue.main.async { [weak self] in + guard let self else{return} + vc.gradientView.applyGradient(colors: [details.color1, details.color2], startPoint: CGPoint(x: 0, y: 0), endPoint: CGPoint(x: 0, y: 0.8)) + vc.nameLabel.textColor = details.textColor + vc.HelloLabel.textColor = details.textColor + vc.welcomeLabel.textColor = details.textColor + vc.homeGrass.image = UIImage(named: details.grass) } -// } - break } } } diff --git a/WOKA/WebSeries/Controller/WebSeriesVC.swift b/WOKA/WebSeries/Controller/WebSeriesVC.swift index 67bd1c1..cc1868a 100644 --- a/WOKA/WebSeries/Controller/WebSeriesVC.swift +++ b/WOKA/WebSeries/Controller/WebSeriesVC.swift @@ -192,7 +192,8 @@ extension WebSeriesVC : TableViewSRC { cell.setData(data: data,selectedCategory: categoryID) } - cell.btnTapped = { [self] (type) -> Void in + cell.btnTapped = { [weak self] (type) -> Void in + guard let self else{return} HapticFeedbackGenerator.shared.simpleSelection() updateFavLikes(type: type, index: indexPath.row) }